storage-bigtable: Upload entries #34099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34099 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 816 816
Lines 219781 219807 +26
=========================================
- Hits 180009 179960 -49
- Misses 39772 39847 +75 |
CriesofCarrots
force-pushed
the
bt-entries
branch
from
da83052
to
eef0f56
Compare
steviez
reviewed
Nov 28, 2023
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Blocks stored on bigtable are flattened, so they don't include the entry data that would allow block hashes to be verified.
Other historical ledger archives (like foundation storage buckets and Old Faithful) do include entry data, but it would provide additional redundancy if the bigtable store were made complete.
Summary of Changes
Add entries table to default bigtable setup
Upload entry summary data in
bigtable_upload(used by bothsolana-ledger-tool bigtable uploadand the BigtableUploadService). Entry-summary data is the entry data minus the actual transactions, plus a little extra indexing data to make it easy to regenerate entries from the flattened list of transactions. (This parallels geyser Entry notifications.)✅
Needs rebase on #34098Handling for deleting entries (on block delete) and warehousing docs will be PRed separately.