stop page aligning shrunk append vecs #34016
Conversation
accounts-db/src/accounts_db.rs
Outdated
| @@ -4114,7 +4112,7 @@ impl AccountsDb { | |||
| self.shrink_collect::<AliveAccounts<'_>>(store, &unique_accounts, &self.shrink_stats); | |||
|
|
|||
| // This shouldn't happen if alive_bytes/approx_stored_count are accurate | |||
| if Self::should_not_shrink(shrink_collect.aligned_total_bytes, shrink_collect.capacity) { | |||
| if Self::should_not_shrink(shrink_collect.alive_total_bytes as u64, shrink_collect.capacity) { | |||
There was a problem hiding this comment.
I'm not really sure what this check is doing. I think it may be saying we shouldn't shrink if the (previously aligned) alive bytes plus a page are bigger than the capacity of the current append vec. So, only shrink if we save at least a page? It adds a page size to alive bytes and compares to the capacity of the original append vec. This data point does not appear to be present on mnb, indicating alive_bytes and approx_stored_count are correct.
There was a problem hiding this comment.
This call to should_not_shrink is the same call we made prior to trying to shrink this append vec. This is a sanity check to make sure we still think we should've shrunk this one.
|
Changes look good. I think there are a few more tests need to be fixed with the rename of the member var. |
Codecov Report
@@ Coverage Diff @@
## master #34016 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 811 811
Lines 219412 219402 -10
=========================================
- Hits 179792 179732 -60
- Misses 39620 39670 +50 |
|
I have fixed the build and tests for the PR. |
HaoranYi
added
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
|
lgtm. ty @HaoranYi |
Problem
There's been an effort underway to make append vecs the correct size. Among other benefits, this allows readers to not have to be told how many bytes are valid in an append vec.
I found a new place where we pad the size of an append vec to a page size.
Summary of Changes
Remove alignment to a page size when we're shrinking.
Fixes #