scripts/cargo-clippy.sh: Extract our non-trivial cargo clippy command
#33982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI uses a number of parameters when running `cargo clippy`. Repeating the same command manually requires some copy/pasting. It is easier when there is a common script that can be run by everyone.
mergify bot
added a commit
that referenced
this pull request
Dec 10, 2023
* ci: add macos clippy test (#34272) * ci: add clippy test for macos and windows * ci: remove windows from clippy test * ci: cancel cargo clippy on Github Actions when new commits comming * ci: set -e for .github/scripts/cargo-clippy-before-script.sh (cherry picked from commit 4832b4e) * scripts/cargo-clippy.sh: Extract our non-trivial cargo clippy command (manual backport of #33982) --------- Co-authored-by: Yihau Chen <[email protected]> Co-authored-by: yihau <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Dec 10, 2023
* ci: add macos clippy test (#34272) * ci: add clippy test for macos and windows * ci: remove windows from clippy test * ci: cancel cargo clippy on Github Actions when new commits comming * ci: set -e for .github/scripts/cargo-clippy-before-script.sh (cherry picked from commit 4832b4e) * scripts/cargo-clippy.sh: Extract our non-trivial cargo clippy command (manual backport of #33982) --------- Co-authored-by: Yihau Chen <[email protected]> Co-authored-by: yihau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CI uses a number of parameters when running
cargo clippy. Repeating the same command manually requires some copy/pasting. It is easier when there is a common script that can be run by everyone.Summary of Changes
Add
scripts/cargo-clippy.shthat is used by CI and is executable directly.