Adds iter_ones()
to RollingBitField
#33956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During shrink, we are given a set of 'candidate slots' to inspect. Currently, these candidates are a HashSet (with the
nohash-hasher
). To make this faster, we can change the ShrinkCandidates to a RollingBitField. However, RollingBitField does not have a method to iterate over the set bits, so this means we would have to create a Vec of all the set bits, even though we don't need the Vec.It would be better to avoid this unnecessary allocation, and instead just iterate the set bits.
Summary of Changes
Add
iter_ones()
to RollingBitField.