Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AtomicAge to bucket map holder #33841

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

I'm investigating making the accounts index flushing interval longer, which will need to change the Age type from a u8 to something bigger. There is an atomic and non-atomic set of types for the Age. They are used in multiple places, and it would be safer to ensure they are always the same.

Summary of Changes

Add an AtomicAge alias, and assert it's the same size as Age.

@brooksprumo brooksprumo self-assigned this Oct 24, 2023
@brooksprumo brooksprumo marked this pull request as ready for review October 24, 2023 19:00
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #33841 (4f4e69a) into master (b0dcaf2) will increase coverage by 0.0%.
Report is 10 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33841   +/-   ##
=======================================
  Coverage    81.8%    81.9%           
=======================================
  Files         809      809           
  Lines      217643   217627   -16     
=======================================
  Hits       178247   178247           
+ Misses      39396    39380   -16     

Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit bd1080b into solana-labs:master Oct 25, 2023
32 checks passed
@brooksprumo brooksprumo deleted the index/atomic-age branch October 25, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants