Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes #[allow(dead_code)] in StorableAccounts impl #33821

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Oct 24, 2023

Problem

Some impls of StorableAccounts are erroneously marked with #[allow(dead_code)].

Summary of Changes

Remove the annotation.

@brooksprumo brooksprumo self-assigned this Oct 24, 2023
@brooksprumo brooksprumo marked this pull request as ready for review October 24, 2023 01:39
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #33821 (cbce701) into master (8954689) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #33821     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         807      807             
  Lines      217305   217305             
=========================================
- Hits       177935   177907     -28     
- Misses      39370    39398     +28     

@brooksprumo brooksprumo added the automerge Merge this Pull Request automatically once CI passes label Oct 24, 2023
@mergify mergify bot merged commit abf5186 into solana-labs:master Oct 24, 2023
33 checks passed
@brooksprumo brooksprumo deleted the dead-code/storable-accounts branch October 24, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants