test: check the existence of target_path_parent before detelting #33812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33812 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 807 807
Lines 217406 217406
=========================================
- Hits 178043 178008 -35
- Misses 39363 39398 +35 |
dmakarov
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
when
install_if_missingreceives a "permission denied" error,target_path_parentdoesn't exist. if we remove it without checking, the real error will be hidden and return a "directory doesn't exist" errorSummary of Changes
check the existence of target_path_parent before delete it