ancient pack: add low water mark #33785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
oc13
branch
3 times, most recently
from
fb35ac2
to
ccbf033
Compare
Codecov Report
@@ Coverage Diff @@
## master #33785 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217428 217438 +10
=======================================
+ Hits 178056 178075 +19
+ Misses 39372 39363 -9 |
brooksprumo
reviewed
Oct 23, 2023
| @@ -182,15 +182,17 @@ impl AncientSlotInfos { | |||
| self.shrink_indexes.clear(); | |||
| let total_storages = self.all_infos.len(); | |||
| let mut cumulative_bytes = 0u64; | |||
| let low_threshold = max_storages * 50 / 100; | |||
There was a problem hiding this comment.
Is the current impl preferred over a divide by two?
Suggested change
| let low_threshold = max_storages * 50 / 100; | |
| let low_threshold = max_storages / 2; |
There was a problem hiding this comment.
Perhaps, introduce a const variable for this?
There was a problem hiding this comment.
I was thinking this is more tunable than /2. 80%, 20%, etc. Ultimately we might make this a tuning parameter? Even a cli argument? This choice seems sufficient for the moment based on mnb monitoring. And it beats the current 100 slots at a time impl.
brooksprumo
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we disable rewrites, we will accumulate old append vecs & slots. We use ancient append vec packing to combine those.
It is more efficient to pack a larger range of slots at a time instead of a small amount each call.
Summary of Changes
Add a low water mark. By default, when there are more than 10k ancient slots, the algorithm will pack down to 5k ancient slots. Then, the algorithm will do nothing until 10k is exceeded again.
Fixes #