Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses AccountHash in tiered storage #33763

Merged

Conversation

brooksprumo
Copy link
Contributor

Problem

Next on the list of places we use a bare Hash to mean an account's hash is the tiered storage code. So use an AccountHash when we need the hash of an account.

Summary of Changes

Use AccountHash in tiered storage.

@brooksprumo brooksprumo self-assigned this Oct 19, 2023
@brooksprumo brooksprumo marked this pull request as ready for review October 19, 2023 02:10
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #33763 (2b4515c) into master (0fcc0a0) will decrease coverage by 0.1%.
The diff coverage is 84.2%.

@@            Coverage Diff            @@
##           master   #33763     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         806      806             
  Lines      217905   217905             
=========================================
- Hits       178278   178273      -5     
- Misses      39627    39632      +5     

Copy link
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking about this when I first saw the AccountHash PR. Thanks for working on this PR!

@brooksprumo brooksprumo merged commit 4e5c545 into solana-labs:master Oct 19, 2023
31 checks passed
@brooksprumo brooksprumo deleted the account-hash/tiered-storage branch October 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants