Removes cap_accounts_data_allocations_per_transaction featurization #33754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
the
feature-gate
Codecov Report
@@ Coverage Diff @@
## master #33754 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217905 217893 -12
=======================================
+ Hits 178278 178324 +46
+ Misses 39627 39569 -58 |
t-nelson
previously approved these changes
Oct 18, 2023
Comment on lines
1600
to
-1602
| && !invoke_context | ||
| .feature_set | ||
| .is_active(&cap_accounts_data_allocations_per_transaction::id())) | ||
| || (status == MAX_INSTRUCTION_TRACE_LENGTH_EXCEEDED |
There was a problem hiding this comment.
ideally don't combine feature gate logic with other logic to make these removal diffs cleaner
brooksprumo
force-pushed
the
accounts-data-len/tx/remove
branch
from
4efc6af
to
5859609
Compare
|
Rebased and force-pushed to resolve a merge conflict. No actual code changes. |
Lichtso
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that the
cap_accounts_data_allocations_per_transactionfeature-gate has been enabled on all clusters, its code can be removed.Summary of Changes
Remove the code for the feature-gate.
Fixes #27375
Feature Gate Issue: #27375