[TieredStorage] HotStorageReader::get_account_meta_from_offset() #33724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhchiang-sol
force-pushed
the
ts-get-meta-from-offset
branch
from
493039f
to
5af0429
Compare
Codecov Report
@@ Coverage Diff @@
## master #33724 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217913 217945 +32
=======================================
+ Hits 178286 178314 +28
- Misses 39627 39631 +4 |
yhchiang-sol
force-pushed
the
ts-get-meta-from-offset
branch
from
5af0429
to
efd08d2
Compare
|
Will do a rebase once the PR gets approval. |
brooksprumo
reviewed
Oct 18, 2023
yhchiang-sol
force-pushed
the
ts-get-meta-from-offset
branch
from
11ec354
to
bdea578
Compare
|
Rebase & squash. |
brooksprumo
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
HotStorageReader currently only implements get_footer(). It does not
have a function to obtain the account meta.
Summary of Changes
This PR implements HotStorageReader::get_account_meta_from_offset().
A function that returns the account meta located at the specified offset.
This will be the helper function that will be later used to obtain the account
meta when the offset is available from the index block of a hot storage file.
Test Plan
A new test is included in this PR.