Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to publish solana-wen-restart so we can publish 1.18.0 later. #33662

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

wen-coding
Copy link
Contributor

Publish solana-wen-restart for now, otherwise we would have problem compiling 1.18.0 later.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #33662 (c0fb22a) into master (0f82662) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #33662   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         806      806           
  Lines      217544   217544           
=======================================
+ Hits       178032   178082   +50     
+ Misses      39512    39462   -50     

@wen-coding wen-coding merged commit 295d610 into solana-labs:master Oct 11, 2023
15 checks passed
@steviez
Copy link
Contributor

steviez commented Oct 11, 2023

Dang, didn't even have enough time to mark ship it but confirmed that I see the name is "reserved" and owned by a solana account:
https://crates.io/crates/solana-wen-restart

@t-nelson
Copy link
Contributor

hmm... did this not trigger any ci? that's broken 🤔

@steviez
Copy link
Contributor

steviez commented Oct 11, 2023

hmm... did this not trigger any ci? that's broken 🤔

My comment was a joke at very fast request-for-review / ship-it / merge between you and Wen. I think Wen let it go through CI before adding us as reviewers; I see this build https://buildkite.com/solana-labs/solana/builds/103035

@wen-coding
Copy link
Contributor Author

Yeah, I normally do that so I can fix all the lint errors before the reviewers had a chance ;-)

@t-nelson
Copy link
Contributor

no i mean ci didn't trigger anything but the "is new crate name reserved" check. i think ideally we'd at least run test-sanity.sh as well

@wen-coding wen-coding deleted the publish_wen_restart_crate branch March 5, 2024 20:09
@wen-coding wen-coding self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants