stop padding new append vecs to page size #33658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We no longer 'append' to append vecs. We know the full size when we are ready to write to them. So, it is no longer necessary to pad them to the next full page size. This makes 100% of the data in the file required and the used length equal to the allocated length.
This pr was attempted as #33607 but reverted as #33634.
There were 2 conflicting prs. There was a failing test. That test has now been fixed.
Summary of Changes
Fixes #