Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

chore: impl decode for UiAccountData #33632

Merged
merged 1 commit into from
Nov 6, 2023
Merged

chore: impl decode for UiAccountData #33632

merged 1 commit into from
Nov 6, 2023

Conversation

xoac
Copy link
Contributor

@xoac xoac commented Oct 10, 2023

Problem

It's hard to use UiAccountData with parse_token function.

Summary of Changes

  • encapsulate decode function deeper

@mergify mergify bot added community Community contribution need:merge-assist labels Oct 10, 2023
@mergify mergify bot requested a review from a team October 10, 2023 18:39
@joncinque joncinque added the CI Pull Request is ready to enter CI label Oct 12, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Oct 12, 2023
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but let's be sure it passes CI -- can you rebase and ping me when that's done? Then I can kick off CI again

@xoac
Copy link
Contributor Author

xoac commented Oct 30, 2023

@joncinque rebased

@joncinque joncinque added the CI Pull Request is ready to enter CI label Nov 6, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #33632 (e4a46e3) into master (cdc2841) will increase coverage by 0.0%.
Report is 15 commits behind head on master.
The diff coverage is 75.0%.

@@           Coverage Diff           @@
##           master   #33632   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         809      809           
  Lines      218060   218063    +3     
=======================================
+ Hits       178630   178652   +22     
+ Misses      39430    39411   -19     

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@joncinque joncinque merged commit 63fd5cf into solana-labs:master Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants