Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure in updating GIT index of cargo registry server #33628

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Oct 10, 2023

Problem

The cargo registry server fails to start if the index configuration changes (e.g. due to change in port or IP address)

thread 'main' panicked at cargo-registry/src/dummy_git_index.rs:80:18:
Failed to get tree: Error { code: -1, klass: 14, message: "failed to insert entry: invalid object specified - git" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Summary of Changes

The config change requires a new commit to the GIT index. The staging of the commit was adding all the files, including .git folder. That was causing the issue. This PR adds only the required files to the stage/commit.

Fixes #

@pgarg66 pgarg66 marked this pull request as ready for review October 10, 2023 17:25
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #33628 (b326da1) into master (1d91b60) will increase coverage by 0.1%.
Report is 17 commits behind head on master.
The diff coverage is 91.4%.

@@            Coverage Diff            @@
##           master   #33628     +/-   ##
=========================================
+ Coverage    81.7%    81.8%   +0.1%     
=========================================
  Files         807      807             
  Lines      218252   217896    -356     
=========================================
+ Hits       178438   178448     +10     
+ Misses      39814    39448    -366     

@pgarg66 pgarg66 requested a review from Lichtso October 10, 2023 17:56
@pgarg66 pgarg66 merged commit ad949b2 into solana-labs:master Oct 10, 2023
16 checks passed
@pgarg66 pgarg66 deleted the fix-cargo-registry-dummy-git branch October 10, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants