Define PohRecorder set_bank related test helper methods #33626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
changed the title
ryoqun
commented
Oct 10, 2023
| @@ -642,6 +642,16 @@ impl PohRecorder { | |||
| let _ = self.flush_cache(false); | |||
| } | |||
|
|
|||
| #[cfg(feature = "dev-context-only-utils")] | |||
| pub fn set_bank_for_test(&mut self, bank: Arc<Bank>) { | |||
| self.set_bank(bank, false) | |||
There was a problem hiding this comment.
i eliminated these falses at all call-sites as a bonus.
ryoqun
commented
Oct 10, 2023
| } | ||
|
|
||
| #[cfg(test)] | ||
| pub fn set_bank_with_transaction_index_for_test(&mut self, bank: Arc<Bank>) { |
There was a problem hiding this comment.
fyi, this is only used once.... another justification for hiding the track_transaction_indexes bool arg at this wrapper...
|
merged this knowing the ci failure is fixed in the master. rebase would need another full ci run and lgtm from someone. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
my scheduler thing needs to introduce rather invasive code changes including the
BankWithSchedulerwrapping, which touches poh recorder code.Summary of Changes
Prepare some helper functions.
extracted from: #33070
note that this pr is quite similar to the previous prep. pr: #33537