Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes unused legacy-snapshot-hashes api in gossip #33593

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

behzadnouri
Copy link
Contributor

Problem

unused legacy-snapshot-hashes code in gossip.

Summary of Changes

removed unused legacy-snapshot-hashes api in gossip

solana-labs#33576
stops broadcasting legacy snapshot hashes over gossip, and this commit
removes unused legacy snapshot hashed code in gossip.
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thank you for doing this. I was planning on asking you specifically what's the way to handle deprecation of the Legacy Snapshot Hashes and putting up a PR, but you beat me to it!

@behzadnouri behzadnouri added the automerge Merge this Pull Request automatically once CI passes label Oct 9, 2023
@mergify mergify bot merged commit 1d91b60 into solana-labs:master Oct 9, 2023
16 checks passed
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #33593 (bbd2bf4) into master (7afb11f) will decrease coverage by 0.1%.
Report is 5 commits behind head on master.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #33593     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         807      807             
  Lines      218287   218251     -36     
=========================================
- Hits       178524   178473     -51     
- Misses      39763    39778     +15     

@behzadnouri behzadnouri deleted the rm-legacy-snapshot branch October 9, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants