Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses IntSet in AccountsDb::calc_delete_dependencies() #33528

Merged

Conversation

brooksprumo
Copy link
Contributor

Problem

#33521 added solana-nohash-hasher. In AccountsDb::calc_delete_dependencies(), we create a few lists to track slots. These do not need to cryptographically secure, and thus can use IntSet for better performance.

Summary of Changes

Uses IntSet in AccountsDb::calc_delete_dependencies()

@brooksprumo brooksprumo self-assigned this Oct 4, 2023
@brooksprumo brooksprumo marked this pull request as ready for review October 4, 2023 19:24
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #33528 (dbb3223) into master (ec1115e) will decrease coverage by 0.2%.
Report is 1007 commits behind head on master.
The diff coverage is 88.0%.

@@            Coverage Diff            @@
##           master   #33528     +/-   ##
=========================================
- Coverage    81.8%    81.7%   -0.2%     
=========================================
  Files         766      803     +37     
  Lines      209028   217904   +8876     
=========================================
+ Hits       171148   178185   +7037     
- Misses      37880    39719   +1839     

Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit befc903 into solana-labs:master Oct 4, 2023
16 checks passed
@brooksprumo brooksprumo deleted the nohash/calc-delete-dependencies branch October 4, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants