Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty string for SOLANA_METRICS_CONFIG sanity checking #33515

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jbiseda
Copy link
Contributor

@jbiseda jbiseda commented Oct 4, 2023

Problem

SOLANA_METRICS_CONFIG sanity checking fails for an empty string.

Summary of Changes

  • Relax sanity check to treat an empty string the same as an unset env variable.
  • Move SOLANA_METRICS_CONFIG sanity checking earlier in startup

original change for reference: sanity check metrics configuration #32799

Fixes #

@jbiseda jbiseda force-pushed the jbiseda/metrics-sanity-update branch from 16f2a3c to 14f9c9c Compare October 4, 2023 00:39
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #33515 (0964faf) into master (7006a6f) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is 50.0%.

@@            Coverage Diff            @@
##           master   #33515     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         806      806             
  Lines      217458   217460      +2     
=========================================
- Hits       177987   177977     -10     
- Misses      39471    39483     +12     

@jbiseda jbiseda force-pushed the jbiseda/metrics-sanity-update branch 3 times, most recently from 15dfa03 to 4b73f2f Compare October 6, 2023 21:59
@jbiseda jbiseda marked this pull request as ready for review October 6, 2023 22:08
@jbiseda jbiseda requested a review from t-nelson October 6, 2023 22:09
@jbiseda jbiseda force-pushed the jbiseda/metrics-sanity-update branch from 4b73f2f to a7243db Compare October 10, 2023 19:11
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jbiseda jbiseda force-pushed the jbiseda/metrics-sanity-update branch from a7243db to 0964faf Compare October 11, 2023 01:03
@jbiseda jbiseda merged commit 0f82662 into solana-labs:master Oct 11, 2023
16 checks passed
@jbiseda jbiseda deleted the jbiseda/metrics-sanity-update branch October 11, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants