Create runtime-transaction crate to build transaction types with state for runtime use #33471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
force-pushed
the
runtime-transaction-state-machine-via-trait
branch
2 times, most recently
from
0ca1826
to
09682ad
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #33471 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 812 816 +4
Lines 219645 219688 +43
=======================================
+ Hits 179922 180003 +81
+ Misses 39723 39685 -38 |
tao-stones
force-pushed
the
runtime-transaction-state-machine-via-trait
branch
2 times, most recently
from
c9d6796
to
9f6da2c
Compare
tao-stones
changed the title
tao-stones
force-pushed
the
runtime-transaction-state-machine-via-trait
branch
2 times, most recently
from
3da7d1f
to
294382c
Compare
tao-stones
force-pushed
the
runtime-transaction-state-machine-via-trait
branch
from
294382c
to
edac647
Compare
apfitzge
reviewed
Oct 20, 2023
apfitzge
reviewed
Oct 31, 2023
tao-stones
force-pushed
the
runtime-transaction-state-machine-via-trait
branch
from
f48d15d
to
90dc6ef
Compare
apfitzge
reviewed
Nov 15, 2023
apfitzge
reviewed
Nov 15, 2023
… that comes with metadata
…ing traits for transacion_meta
Co-authored-by: Andrew Fitzgerald <[email protected]>
Co-authored-by: Andrew Fitzgerald <[email protected]>
tao-stones
force-pushed
the
runtime-transaction-state-machine-via-trait
branch
from
90dc6ef
to
43eda39
Compare
apfitzge
approved these changes
Nov 16, 2023
t-nelson
reviewed
Nov 17, 2023
| @@ -32,6 +32,11 @@ impl SanitizedVersionedTransaction { | |||
| pub fn get_message(&self) -> &SanitizedVersionedMessage { | |||
| &self.message | |||
| } | |||
|
|
|||
| /// Consumes the SanitizedVersionedTransaction, returning the fields individually. | |||
| pub fn destruct(self) -> (Vec<Signature>, SanitizedVersionedMessage) { | |||
There was a problem hiding this comment.
this could be an impl From<SanitizedVersionedTransaction> for (Vec<Signature>, SanitizedVersionedMessage) if not make the fields pub instead of pub (crate) to allow in place destructuring
There was a problem hiding this comment.
Fields on SanitizedVersionedMessage should not be pub. Them being private is intentional, see the previous discussion on it: #33471 (comment)
There was a problem hiding this comment.
From impl, then. i would assume a method called destruct() to do something... destructive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add a transaction type for runtime that contains encapsulated internal metadata, which can be accessed/updated as sanitized transaction goes through execution pipeline.
It is an Alternative to #33418
Summary of Changes
Fixes #