Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(solana-frozen-abi): remove unused deps #33436

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

yihau
Copy link
Member

@yihau yihau commented Sep 28, 2023

Summary of Changes

remove some unused deps

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #33436 (f0f5557) into master (c0100b1) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #33436     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         798      798             
  Lines      217100   217100             
=========================================
- Hits       178001   177960     -41     
- Misses      39099    39140     +41     

@yihau yihau changed the title ci test chore(solana-frozen-abi): remove unused deps Sep 29, 2023
@yihau yihau marked this pull request as ready for review September 29, 2023 03:54
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @dmakarov added otherwise unused dependencies here and in a couple other crates to explicitly reduce the number of rebuilds. Let's get his take

@yihau yihau merged commit c9d04bc into solana-labs:master Oct 4, 2023
27 checks passed
@yihau yihau deleted the udeps-frozen-abi branch October 4, 2023 04:00
tao-stones pushed a commit to tao-stones/solana that referenced this pull request Oct 6, 2023
* chore: remove unused deps

* ci: increase regression of build redundancy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants