This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
in hash calc, delete old cache files that will not be used earlier #33432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33432 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 807 807
Lines 218287 218303 +16
=========================================
+ Hits 178524 178536 +12
- Misses 39763 39767 +4 |
brooksprumo
reviewed
Sep 28, 2023
brooksprumo
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Improving performance of hash calc.
Summary of Changes
When preparing to scan append vecs, first delete all existing cache files that will no longer be used. For example, if a slot was dropped or shrunk, then the cache file containing that file will be rewritten from scratch. So, that old file will never be useful again.
Fixes #