Bank's don't know their id, don't freeze() their parents, or freeze() on merge, which is necessary for #2884 #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add bank.id() which can be used by BankForks, blocktree_processor * add bank.hash(), make hash_internal_state() private * add bank.freeze()/is_frozen(), also useful for blocktree_processor, eventual freeze()ing in replay
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
========================================
+ Coverage 78.3% 78.3% +<.1%
========================================
Files 126 126
Lines 19609 19639 +30
========================================
+ Hits 15354 15378 +24
- Misses 4255 4261 +6 |
garious
reviewed
Feb 25, 2019
garious
approved these changes
Feb 25, 2019
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Oct 4, 2024
* extract program-pack crate * fix description grammar * requested doc comment change * fix trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes #