Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix flakey partialSign test #27770

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Sep 13, 2022

Problem

There is a partialSign test which tries to cause an exception by changing the first value in a signature to 0 but sometimes that byte is already a 0 and no exception is thrown.

Summary of Changes

  • Ensure that the test always throws an exception by using an invalid signature

Fixes #

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #27770 (8eb18f1) into master (e779032) will increase coverage by 0.3%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #27770     +/-   ##
=========================================
+ Coverage    76.9%    77.2%   +0.3%     
=========================================
  Files          48       55      +7     
  Lines        2505     2889    +384     
  Branches      355      402     +47     
=========================================
+ Hits         1927     2232    +305     
- Misses        448      515     +67     
- Partials      130      142     +12     

@mergify mergify bot merged commit e6687b8 into solana-labs:master Sep 13, 2022
@jstarry jstarry deleted the explorer/flakey-test branch September 14, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants