Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup script to exclude new secp256k1 and hmac/sha256 dependencies #27428

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Update rollup script to exclude new secp256k1 and hmac/sha256 dependencies #27428

merged 2 commits into from
Aug 26, 2022

Conversation

steveluscher
Copy link
Contributor

@steveluscher steveluscher commented Aug 26, 2022

Problem

I always forget to do this, and there's no static analysis to stop this mistake from being made.

Summary of Changes

Test plan

yarn build

Inspect ESM bundles in /lib/. Observe that @noble/hashes and @noble/secp256k1 are no longer inlined.

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #27428 (b144bd1) into master (e779032) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head b144bd1 differs from pull request most recent head 1cc43e3. Consider uploading reports for the commit 1cc43e3 to get more accurate results

@@            Coverage Diff            @@
##           master   #27428     +/-   ##
=========================================
- Coverage    76.9%    76.8%   -0.1%     
=========================================
  Files          48       51      +3     
  Lines        2505     2657    +152     
  Branches      355      363      +8     
=========================================
+ Hits         1927     2043    +116     
- Misses        448      482     +34     
- Partials      130      132      +2     

@steveluscher steveluscher changed the title Update rollup script to exclude new secp256k1 and sha256 dependencies Update rollup script to exclude new secp256k1 and hmac/sha256 dependencies Aug 26, 2022
@steveluscher steveluscher merged commit 713e86e into solana-labs:master Aug 26, 2022
@steveluscher steveluscher deleted the always-forget-to-update-rollup-script branch August 26, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant