[web3.js] Eliminate dependency on URL
class
#27349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
URL
class is not available in all runtimes, namely React Native. For this, web3.js currently depends on a polyfill.Thing is, our use of
URL
is very constrained:https:
I'm all for relying on built-ins, but when the built-in doesn't exist on a target platform, it's worth taking a look at whether you can get away with a minimal implementation of it rather than a full polyfill.
Summary of Changes
URL
class in favor of purpose-built userspace implementations of URL parsing.URL
polyfill and regenerate lockfilesTest plan
new URL
insrc/
; no more uses.Addresses solana-labs/solana-web3.js#1103
Closes: #27001