Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web3.js): move sinon-chai to devDependencies #25151

Merged
merged 1 commit into from
May 12, 2022
Merged

chore(web3.js): move sinon-chai to devDependencies #25151

merged 1 commit into from
May 12, 2022

Conversation

beeman
Copy link
Contributor

@beeman beeman commented May 11, 2022

Problem

The sinon-chai package is listed in the dependencies resulting in a warning when using installing with yarn.

$ yarn
yarn install v1.22.18
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "@solana/web3.js > [email protected]" has unmet peer dependency "chai@^4.0.0".
warning "@solana/web3.js > [email protected]" has unmet peer dependency "sinon@>=4.0.0".
[4/4] 🔨  Building fresh packages...
✨  Done in 12.79s.

Summary of Changes

  • move sinon-chai to devDependencies

@mergify mergify bot added the community Community contribution label May 11, 2022
@mergify mergify bot requested a review from a team May 11, 2022 21:44
@steveluscher steveluscher merged commit 0514e83 into solana-labs:master May 12, 2022
@beeman beeman deleted the beeman/sinon-chai branch May 12, 2022 00:51
@snyk-bot snyk-bot mentioned this pull request Jun 2, 2022
Open
@Balantion2020 Balantion2020 mentioned this pull request Jun 3, 2022
Open
This was referenced Jun 4, 2022
Open
Open
Open
@Balantion2020 Balantion2020 mentioned this pull request Jun 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beeman @steveluscher