test: repair web3.js getBlocks tests #24813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These tests were never correct, because
getBlocks
is supposed to return the blocks betweenstartSlot
andendSlot
inclusive.I think they were accidentally working before, because of a bug in the validator that has since been fixed in #23853.
Summary of Changes
startSlot
andendSlot
inclusive.startSlot
to whateverfirstAvailableBlock
returns (this will make the web3.js tests less flaky 🎉)