Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explicit module declaration to type definitions #16219

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Mar 30, 2021

Problem

The generated typescript declarations are not prioritized over ambient module declarations in a project's transitive dependencies. This causes strange type errors because the wrong type declaration is resolved for web3

Summary of Changes

  • Wrap type declaration in module declaration

Fixes #16207

@jstarry jstarry added the CI Pull Request is ready to enter CI label Mar 30, 2021
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Mar 30, 2021
@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Mar 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2021

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #16219 (3476e90) into master (ba377b7) will decrease coverage by 9.5%.
The diff coverage is n/a.

❗ Current head 3476e90 differs from pull request most recent head f02cb70. Consider uploading reports for the commit f02cb70 to get more accurate results

@@             Coverage Diff             @@
##           master   #16219       +/-   ##
===========================================
- Coverage    80.0%    70.4%     -9.6%     
===========================================
  Files         410       28      -382     
  Lines      109501     1735   -107766     
  Branches        0      227      +227     
===========================================
- Hits        87695     1223    -86472     
+ Misses      21806      428    -21378     
- Partials        0       84       +84     

@jstarry jstarry merged commit c959c5d into solana-labs:master Mar 30, 2021
@jstarry jstarry deleted the web3/fix-types branch March 30, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3.js: TypeError regression
2 participants