Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup test utilities #11723

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Cleanup test utilities #11723

merged 2 commits into from
Aug 20, 2020

Conversation

carllin
Copy link
Contributor

@carllin carllin commented Aug 20, 2020

Problem

  1. blockstore::add_tree() does not make replayable/verifiable slots for tests
  2. ValidatorVoteKeypair is inconsistent with 1.2, making backports ugly

Summary of Changes

Resolve above

Fixes #

@carllin carllin added the automerge Merge this Pull Request automatically once CI passes label Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #11723 into master will decrease coverage by 0.0%.
The diff coverage is 87.7%.

@@            Coverage Diff            @@
##           master   #11723     +/-   ##
=========================================
- Coverage    82.0%    82.0%   -0.1%     
=========================================
  Files         330      330             
  Lines       76733    76742      +9     
=========================================
- Hits        62972    62955     -17     
- Misses      13761    13787     +26     

@mergify mergify bot merged commit b7ed06b into solana-labs:master Aug 20, 2020
This was referenced Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant