Feature check CPI up front #11652
Merged
Feature check CPI up front #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11652 +/- ##
=======================================
Coverage 82.0% 82.1%
=======================================
Files 330 330
Lines 76059 76107 +48
=======================================
+ Hits 62428 62512 +84
+ Misses 13631 13595 -36 |
This was referenced Aug 18, 2020
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2020
(cherry picked from commit 4196686) # Conflicts: # programs/bpf_loader/src/syscalls.rs
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2020
(cherry picked from commit 4196686)
mergify bot
added a commit
that referenced
this pull request
Aug 22, 2020
(cherry picked from commit 4196686) Co-authored-by: Jack May <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cross-program invocation is feature checked in the runtime but we can check it much earlier and not expose the syscall at all
Summary of Changes
Check during syscall registration
Fixes #