-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RpcClient: get_token_accounts_by_owner now returns UiTokenAccounts #11364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example usage in solana-labs/solana-program-library#188 |
6 tasks
CriesofCarrots
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, awesome! Thought this might be a likely next step. Lgtm
Codecov Report
@@ Coverage Diff @@
## master #11364 +/- ##
=========================================
- Coverage 82.3% 82.3% -0.1%
=========================================
Files 315 315
Lines 74168 74224 +56
=========================================
+ Hits 61084 61103 +19
- Misses 13084 13121 +37 |
This was referenced Dec 15, 2021
This was referenced May 16, 2022
This was referenced May 23, 2023
This was referenced Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_token_accounts_by_owner()
was returningAccount
structs, which is just a bunch of octets. Instead decode (on the client side) into a more usefulUiTokenAccounts
so the client doesn't need to invoke solana_account_decoder themselves.Freebee: add
get_token_account()
to fetch/decode (client side!) a token account.I didn't add support for mint or multisig yet, I imagine we'd add aget_token_mint_account()
andget_token_multisig_account()
when that need arises