Feature Gate: Deprecate executable meta flag update in bpf loader

[HaoranYi]

SIMD

SIMD-0094

Description

Using account's owner and loader metadata stored in account's data can tell us whether the account is executable. Therefore, we don't need to set account's executable meta when deploy the program by bpf loader.
When this feature is activated, bpf loader will no longer write true to account's executable meta.

Feature ID

k6uR1J9VtKJnTukBV2Eo15BEy434MBg8bT6hHQgmU8v

Activation Method

Single Core Contributor

Deployment Considerations

NA

Minimum Beta Version

No response

Minimum Stable Version

No response

Testnet Activation Epoch

No response

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response

[CriesofCarrots]

SIMD link does not link to a SIMD

[HaoranYi]

SIMD link does not link to a SIMD

Linked.

[billythedummy]

Did you guys check if there are any currently mainnet-deployed programs that for example check the executable flag on a program AccountInfo before CPI-ing it? They will stop working with any new programs deployed after this feature. Probably also want to check with anchor if they're using the executable flag for any account checks and the like.

cc @acheroncrypto

Update: nvm correct me if i'm wrong but this doesn't change the AccountInfo struct that's available to programs since the executable field is serialized with the return of the updated function:

solana/programs/bpf_loader/src/serialization.rs

Line 481 in 8fde8d2

s.write::<u8>(borrowed_account.is_executable(feature_set) as u8);

. No plans to deprecate AccountInfo.executable, right?

[acheroncrypto]

Probably also want to check with anchor if they're using the executable flag for any account checks and the like.

cc @acheroncrypto

Anchor uses the executable flag in some places but I think that's fine because #34194 doesn't seem to affect programs.

[HaoranYi]

Did you guys check if there are any currently mainnet-deployed programs that for example check the executable flag on a program AccountInfo before CPI-ing it? They will stop working with any new programs deployed after this feature. Probably also want to check with anchor if they're using the executable flag for any account checks and the like.

cc @acheroncrypto

Update: nvm correct me if i'm wrong but this doesn't change the AccountInfo struct that's available to programs since the executable field is serialized with the return of the updated function:

solana/programs/bpf_loader/src/serialization.rs

Line 481 in 8fde8d2

s.write::<u8>(borrowed_account.is_executable(feature_set) as u8);

. No plans to deprecate AccountInfo.executable, right?

Yes, that's correct. This feature didn't change AccountInfo.executable visible to the runtime. It only affects the account's executable metadata stored in accounts-db, which are ignored anyway when the feature is activated.

In future, we may consider removing or repurposing account's executable metadata store in accounts-db. But that's out of the scope of this feature.