refactor(experimental): add simulateTransaction RPC call #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcintyre94
force-pushed
the
simulate-tx
branch
from
d29c221
to
f1dda4e
Compare
buffalojoec
reviewed
Aug 21, 2023
packages/rpc-core/src/rpc-methods/__tests__/simulate-transaction-test.ts
Show resolved
Hide resolved
packages/rpc-core/src/rpc-methods/__tests__/simulate-transaction-test.ts
Show resolved
Hide resolved
|
Moved this to draft - this API can return Should probably do after #1528 to make it less annoying! |
mcintyre94
force-pushed
the
simulate-tx
branch
from
f1dda4e
to
f293b01
Compare
|
lgtm but summoning @steveluscher |
<3 |
steveluscher
approved these changes
Aug 23, 2023
Comment on lines
27
to
46
| // Both are optional booleans, but conflict - so cannot both be true | ||
| type SigVerifyAndReplaceRecentBlockhashConfig = | ||
| | Readonly<{ | ||
| /** if `true` the transaction signatures will be verified (conflicts with `replaceRecentBlockhash`) */ | ||
| sigVerify: true; | ||
| /** if `true` the transaction recent blockhash will be replaced with the most recent blockhash. (conflicts with `sigVerify`) */ | ||
| replaceRecentBlockhash?: false; | ||
| }> | ||
| | Readonly<{ | ||
| /** if `true` the transaction recent blockhash will be replaced with the most recent blockhash. (conflicts with `sigVerify`) */ | ||
| replaceRecentBlockhash: true; | ||
| /** if `true` the transaction signatures will be verified (conflicts with `replaceRecentBlockhash`) */ | ||
| sigVerify?: false; | ||
| }> | ||
| | Readonly<{ | ||
| /** if `true` the transaction signatures will be verified (conflicts with `replaceRecentBlockhash`) */ | ||
| sigVerify?: false; | ||
| /** if `true` the transaction recent blockhash will be replaced with the most recent blockhash. (conflicts with `sigVerify`) */ | ||
| replaceRecentBlockhash?: false; | ||
| }>; |
packages/rpc-core/src/rpc-methods/__tests__/simulate-transaction-test.ts
Show resolved
Hide resolved
packages/rpc-core/src/rpc-methods/__tests__/simulate-transaction-test.ts
Outdated
Show resolved
Hide resolved
|
|
||
| await expect(resultPromise).rejects.toMatchObject({ | ||
| code: -32602 satisfies (typeof SolanaJsonRpcErrorCode)['JSON_RPC_INVALID_PARAMS'], | ||
| message: expect.stringContaining('failed to fill whole buffer'), |
packages/rpc-core/src/rpc-methods/__tests__/simulate-transaction-test.ts
Show resolved
Hide resolved
mcintyre94
force-pushed
the
simulate-tx
branch
4 times, most recently
from
69db34b
to
d9ffdf3
Compare
| value: expect.objectContaining({ | ||
| accounts: [ | ||
| expect.objectContaining({ | ||
| // falls back to base64 |
There was a problem hiding this comment.
This comment is out of place, right?
There was a problem hiding this comment.
Oops yep, removed!
mcintyre94
force-pushed
the
simulate-tx
branch
from
d9ffdf3
to
10d833c
Compare
|
🎉 This PR is included in version 1.78.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
simulateTransactionRPC call to the experimental web3jscommitmentandminContextSlotare optional, as in most of these configs. Note that herecommitmentdefaults tofinalized. Like withsendTransactionthis means that tests specify the commitment becausefinalizedmay fail shortly after the validator starts up.sigVerifyandreplaceRecentBlockhash, which both default to false. Their mutual exclusivity is enforced with typesencodingparameter defaults to base58, but should be set to base64 since this is deprecated. As withsendTransactionthis means that excluding the config object, or not settingencodingon it, is deprecated. Most tests use thebase64version and I haven't duplicated them all with the deprecatedbase58one.accountsparameter which can be used to request account data for a subset of accounts involved in a transaction. This contains a list of addresses, and an encoding (unrelated to the transaction level one) for those accounts returned. This is responsible for most of the overloads, because thisencodingaffects the structure of the returnedaccounts. Note thatbase58is not supported: https://github.com/solana-labs/solana/blob/7902ac106d1c537149b44143d080247a6ec85891/rpc/src/rpc.rs#L3774The tests in this PR are modified from the
sendTransactionones, including the specific transaction structure used.Ref #1449