Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump typescript from 5.4.5 to 5.5.2 #2850

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 25, 2024

Bumps typescript from 5.4.5 to 5.5.2.

Release notes

Sourced from typescript's releases.

TypeScript 5.5

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits
  • ce2e60e Update LKG
  • f3b21a2 🤖 Pick PR #58931 (Defer creation of barebonesLibSourc...) into release-5.5 (#...
  • 7b1620b 🤖 Pick PR #58811 (fix(58801): "Move to file" on globa...) into release-5.5 (#...
  • 5367ae1 Bump version to 5.5.2 and LKG
  • 02132e5 🤖 Pick PR #58895 (Fix global when typescript.js loade...) into release-5.5 (#...
  • 45b1e3c 🤖 Pick PR #58872 (Fix declaration emit crash) into release-5.5 (#58874)
  • 17933ee 🤖 Pick PR #58810 (Fixed declaration emit issue relate...) into release-5.5 (#...
  • 552b07e 🤖 Pick PR #58786 (Fixed declaration emit crash relate...) into release-5.5 (#...
  • 39c9eeb Pick #58857 to release-5.5 (#58858)
  • 2b0009c 🤖 Pick PR #58846 (Ensure the updates with crashes rev...) into release-5.5 (#...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the automerge Merge this Pull Request automatically once CI passes label Jun 25, 2024
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: f5337e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Jun 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 21.9 MB typescript-bot

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link
Contributor

mergify bot commented Jun 25, 2024

Automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Jun 25, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-5.5.2 branch 2 times, most recently from 3b853df to cc8e11a Compare June 25, 2024 08:17
@steveluscher steveluscher force-pushed the dependabot/npm_and_yarn/typescript-5.5.2 branch 2 times, most recently from 91fe6d1 to 086b1d9 Compare June 25, 2024 16:14
Comment on lines -24 to -25
# Check result
pnpm tsc --types ./test/__shadow-jest-types.d.ts lib/index.d.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This never made any sense, and indeed no longer works in TS 5.5. tsc isn't designed to typecheck TypeScript definition files.

@steveluscher steveluscher changed the title chore: bump typescript from 5.4.5 to 5.5.2 fix: bump typescript from 5.4.5 to 5.5.2 Jun 25, 2024
@steveluscher
Copy link
Collaborator

Sidenote: landing this with fix: in the title just so that semantic-release will do a release.

@steveluscher steveluscher added the automerge Merge this Pull Request automatically once CI passes label Jun 25, 2024
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Jun 25, 2024
Copy link
Contributor

mergify bot commented Jun 25, 2024

Automerge label removed due to a CI failure

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.4.5 to 5.5.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.4.5...v5.5.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@steveluscher steveluscher force-pushed the dependabot/npm_and_yarn/typescript-5.5.2 branch from 086b1d9 to f5337e9 Compare June 25, 2024 16:24
Comment on lines -9 to -16
# Replace export with closing brace for module declaration
sed -i.bak '$s/export {.*};/}/' lib/index.d.ts

# Replace declare's with export's
sed -i.bak 's/declare/export/g' lib/index.d.ts

# Prepend declare module line
sed -i.bak '2s;^;declare module "@solana/web3.js" {\n;' lib/index.d.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@steveluscher steveluscher Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case something brings us back here, the original context for this code.

solana-labs/solana#16219
solana-labs/solana#16207

@steveluscher steveluscher merged commit 17b0b99 into master Jun 25, 2024
8 checks passed
@steveluscher steveluscher deleted the dependabot/npm_and_yarn/typescript-5.5.2 branch June 25, 2024 16:39
Copy link
Contributor

🎉 This PR is included in version 1.93.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant