-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump typescript from 5.4.5 to 5.5.2 #2850
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Automerge label removed due to a CI failure |
3b853df
to
cc8e11a
Compare
91fe6d1
to
086b1d9
Compare
# Check result | ||
pnpm tsc --types ./test/__shadow-jest-types.d.ts lib/index.d.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This never made any sense, and indeed no longer works in TS 5.5. tsc
isn't designed to typecheck TypeScript definition files.
Sidenote: landing this with |
Automerge label removed due to a CI failure |
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.4.5 to 5.5.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.4.5...v5.5.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
086b1d9
to
f5337e9
Compare
# Replace export with closing brace for module declaration | ||
sed -i.bak '$s/export {.*};/}/' lib/index.d.ts | ||
|
||
# Replace declare's with export's | ||
sed -i.bak 's/declare/export/g' lib/index.d.ts | ||
|
||
# Prepend declare module line | ||
sed -i.bak '2s;^;declare module "@solana/web3.js" {\n;' lib/index.d.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to work anymore.
https://github.com/solana-labs/solana-web3.js/actions/runs/9665989204/job/26664439889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case something brings us back here, the original context for this code.
🎉 This PR is included in version 1.93.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Bumps typescript from 5.4.5 to 5.5.2.
Release notes
Sourced from typescript's releases.
Commits
ce2e60e
Update LKGf3b21a2
🤖 Pick PR #58931 (Defer creation of barebonesLibSourc...) into release-5.5 (#...7b1620b
🤖 Pick PR #58811 (fix(58801): "Move to file" on globa...) into release-5.5 (#...5367ae1
Bump version to 5.5.2 and LKG02132e5
🤖 Pick PR #58895 (Fix global when typescript.js loade...) into release-5.5 (#...45b1e3c
🤖 Pick PR #58872 (Fix declaration emit crash) into release-5.5 (#58874)17933ee
🤖 Pick PR #58810 (Fixed declaration emit issue relate...) into release-5.5 (#...552b07e
🤖 Pick PR #58786 (Fixed declaration emit crash relate...) into release-5.5 (#...39c9eeb
Pick #58857 to release-5.5 (#58858)2b0009c
🤖 Pick PR #58846 (Ensure the updates with crashes rev...) into release-5.5 (#...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)