Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove favorite methods from Giphy::Search and Giphy::Client #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove favorite methods from Giphy::Search and Giphy::Client #12

wants to merge 2 commits into from

Conversation

schonstal
Copy link
Contributor

The API no longer has a /favorites endpoint. This resolves #9.

@sogamoso
Copy link
Owner

sogamoso commented Oct 19, 2017 •
edited
Loading

@schonstal thank a lot for helping cleaning the code! Could you please fix the conflicts so that I can merge your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favorites method does not work
2 participants
@schonstal @sogamoso