Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed parameter object in OpenAPI is not required #3246

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fixed parameter object in OpenAPI is not required #3246

merged 1 commit into from
Oct 16, 2023

Conversation

rparree
Copy link
Contributor

@rparree rparree commented Oct 16, 2023

@adamw
Copy link
Member

adamw commented Oct 16, 2023

Can you maybe add a test which would show the desired generated yaml on an example endpoint? I think VerifyYamlTest would be a good place to put such a test

@rparree
Copy link
Contributor Author

rparree commented Oct 16, 2023

i changed the genre parameter of /books/{genre}/{year} in myBookshopYaml and updated the test accordingly. All the other fields kept the required field. Is that sufficient for the test?

@adamw
Copy link
Member

adamw commented Oct 16, 2023

Sorry that's the codegen project, not the serializer 🤦 My bad :) This looks good then :)

@adamw adamw merged commit 0f86d74 into softwaremill:master Oct 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rparree @adamw