Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize SimpleSubscriber for tapir-netty #3548

Closed
kciesielski opened this issue Feb 29, 2024 · 0 comments · Fixed by #3583
Closed

Optimize SimpleSubscriber for tapir-netty #3548

kciesielski opened this issue Feb 29, 2024 · 0 comments · Fixed by #3583
Assignees
@kciesielski
Milestone
Performance

Comments

@kciesielski
Copy link
Member

Our implementation of Reactive Streams shows a significant overhead in the SimpleSubscriber. It gets revealed when running the PostLongBytes performance simulation, where the subscriber has to create a new byte array and copy intermediate arrays into it:
image
Let's optimize the SimpleSubscriber to reduce this overhead.
@kciesielski kciesielski added this to the Performance milestone Feb 29, 2024
@kciesielski kciesielski self-assigned this Mar 8, 2024
@kciesielski kciesielski mentioned this issue Mar 8, 2024
Merged
@kciesielski kciesielski changed the title Optimize SimpleSubscriber.onComplete for tapir-netty Optimize SimpleSubscriber for tapir-netty Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kciesielski kciesielski

Labels
None yet
Projects
None yet
Milestone
Performance
Development

Successfully merging a pull request may close this issue.

Optimize SimpleSubscriber for Netty softwaremill/tapir
1 participant
@kciesielski