Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pekko Scala3 support #3114

Closed
pjfanning opened this issue Aug 17, 2023 · 2 comments · Fixed by #3116
Closed

Pekko Scala3 support #3114

pjfanning opened this issue Aug 17, 2023 · 2 comments · Fixed by #3116
Assignees

Comments

@pjfanning
Copy link
Contributor

Thanks very much for adding Pekko support to Tapir.

One small improvement would be to add Scala3 support for Pekko HTTP. Pekko HTTP 1.0.0 supports Scala 3.3.0 and above.

The sttp client for Pekko has a Scala 3 supporting jar released already..

@pjfanning
Copy link
Contributor Author

@adamw I had a quick look and there are a few compile issues when using Scala 3 to build tapir pekko-http server. One of the issues is apache/pekko-http#304

In the absence of a Pekko HTTP change and release, we could create a org.apache.pekko.TapirPekkoUtil object that has functions to create Pekko Content-Length and Content-Type instances. Scoping the calls to the Pekko classes in a package prefixed as org.apache.pekko will allow compiler-safe access to the package private constructors.

@adamw
Copy link
Member

adamw commented Aug 17, 2023

@pjfanning Turns out we don't really need to use these constructors - see the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants