Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tapir-cats-effect from tapir-cats? #2822

Closed
dvgica opened this issue Apr 5, 2023 · 2 comments · Fixed by #2823
Closed

Split tapir-cats-effect from tapir-cats? #2822

dvgica opened this issue Apr 5, 2023 · 2 comments · Fixed by #2823

Comments

@dvgica
Copy link
Contributor

dvgica commented Apr 5, 2023

I noticed that we have cats-effect on our classpath, despite not using it (our stuff is Akka-based). I tracked it down to tapir-cats (which we are using for the integration with NonEmptyList and other Cats data types). I believe that cats-effect is only pulled in for CatsMonadError which would be unused if you're not using cats-effect, correct?

Nothing against cats-effect, but it seems like an unnecessary dependency for people just using cats-core. Would it make sense to split off tapir-cats-effect with just CatsMonadError in it?

@adamw
Copy link
Member

adamw commented Apr 6, 2023

Sure, sounds reasonable. We should then have tapir-cats and tapir-cats-effect modules. Would you be willing to submit a PR maybe?

@dvgica
Copy link
Contributor Author

dvgica commented Apr 6, 2023

Ok cool, yep I can submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants