Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spray json support for scala 3 #2179

Closed
MichelEdkrantz opened this issue May 13, 2024 · 3 comments
Closed

Spray json support for scala 3 #2179

MichelEdkrantz opened this issue May 13, 2024 · 3 comments

Comments

@MichelEdkrantz
Copy link
Contributor

Hi,
reaching out since my company is using spray json for a lot of things, and we also like your libraries :)

Wanted to check regarding spray json, and scala 3 support. Spray json also has a Scala 3 build, but not linked in your sbt build. Any historic reason for this or not doing this? It might be as easy as adding scala3 below.

If I opened a PR for this, should it be for the client3 or client4?

lazy val sprayJson = (projectMatrix in file("json/spray-json"))
  .settings(commonJvmSettings)
  .settings(
    name := "spray-json",
    libraryDependencies ++= Seq(
      "io.spray" %% "spray-json" % "1.3.6"
    ),
    scalaTest
  )
  .jvmPlatform(scalaVersions = scala2)
  .dependsOn(core, jsonCommon)

@adamw
Copy link
Member

adamw commented May 13, 2024

Probably nobody submitted a patch yet - no other reasons, if the tests pass. Can you maybe create a PR?

@kciesielski
Copy link
Member

kciesielski commented May 15, 2024

If I opened a PR for this, should it be for the client3 or client4?

I think it's worth adding for client3 and client4.

@MichelEdkrantz
Copy link
Contributor Author

MichelEdkrantz commented May 20, 2024

Added another PR here for v3 - #2186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants