Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magnolia scala2-v1.1.5 made generated type-classes not serializable #487

Closed
RustedBones opened this issue Aug 28, 2023 · 3 comments
Closed

Comments

@RustedBones
Copy link
Contributor

RustedBones commented Aug 28, 2023

Last release of magnolia scala2-v1.1.5 introduced a regression, generating not serializable type-classes:

java.io.NotSerializableException: magnolify.cats.HashDerivationSuite$PartialAssignments$macro$111$1$

See test failures in scala-steward PR

@RustedBones RustedBones changed the title magnolia2 1.1.5 made generated type-classes not serializable magnolia scala2-v1.1.5 made generated type-classes not serializable Aug 28, 2023
@adamw
Copy link
Member

adamw commented Aug 29, 2023

Thanks for the report - can you just double-check that 1.1.4 works fine?

@RustedBones
Copy link
Contributor Author

We've already updated to 1.1.4 in main. The PR passed on the same tests.
I think this is the addition of the new object in a non serializable class that causes the issue as object outer must be serializable.

@adamw
Copy link
Member

adamw commented Aug 29, 2023

Releasing 1.1.6 with the problematic PR reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants