Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write to output when no casm_output_path provided #4

Merged
merged 8 commits into from
Dec 22, 2023
Merged

Write to output when no casm_output_path provided #4

merged 8 commits into from
Dec 22, 2023

Conversation

war-in
Copy link
Collaborator

@war-in war-in commented Dec 20, 2023

No description provided.

@war-in war-in requested a review from Arcticae December 20, 2023 18:02
@war-in war-in self-assigned this Dec 20, 2023
piotmag769
piotmag769 reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should stay as required, I don't really see a use case for that (simple debugging is easier when you have the sierra in the file too imo)

@Arcticae
Copy link
Member

@piotmag769 if you want to omit writing file to the hard drive it's really useful since you would just call the binary in other process and read from stdout instead of performing read and write from disk (which is much more expensive)

Arcticae
Arcticae requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we should e2e test this somehow (match the output against a regex?)

Arcticae
Arcticae approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my last review lol i didn't notice the test

piotmag769
piotmag769 reviewed Dec 21, 2023
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
piotmag769
piotmag769 reviewed Dec 21, 2023
View reviewed changes
tests/e2e.rs Outdated Show resolved Hide resolved
tests/e2e.rs Outdated Show resolved Hide resolved
Base automatically changed from war-in/e2e-tests to master December 22, 2023 08:46
@war-in
Merge branch 'master' into war-in/write-to-output
5d11409 
# Conflicts:
#	Cargo.toml
#	tests/data/wrong_sierra.json
#	tests/e2e.rs
@war-in
fmt
194529c
@war-in
use File::create
86d58f8
@war-in war-in merged commit 9fd2fb3 into master Dec 22, 2023
4 checks passed
@war-in war-in deleted the war-in/write-to-output branch December 22, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 left review comments

@Arcticae Arcticae Arcticae approved these changes

Assignees

@war-in war-in

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@war-in @Arcticae @piotmag769