Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling raw sierra #20

Merged
merged 14 commits into from
Feb 9, 2024
Merged

Compiling raw sierra #20

merged 14 commits into from
Feb 9, 2024

Conversation

Arcticae
Copy link
Member

@Arcticae Arcticae commented Feb 1, 2024

Closes #17

@Arcticae Arcticae requested a review from war-in February 1, 2024 16:55
@war-in war-in self-assigned this Feb 2, 2024
@war-in war-in marked this pull request as ready for review February 7, 2024 15:53
src/main.rs Show resolved Hide resolved
tests/e2e/compile_raw.rs Outdated Show resolved Hide resolved
@war-in war-in requested a review from drknzz February 8, 2024 11:09
Copy link

@drknzz drknzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏 nice

src/main.rs Outdated Show resolved Hide resolved
src/commands/compile_raw.rs Outdated Show resolved Hide resolved
src/commands/compile_raw.rs Show resolved Hide resolved
src/commands/compile_raw.rs Outdated Show resolved Hide resolved
src/commands/compile_raw.rs Outdated Show resolved Hide resolved
src/commands/compile_raw.rs Outdated Show resolved Hide resolved
@war-in
Copy link
Collaborator

war-in commented Feb 8, 2024

Usage demo:
foundry-rs/starknet-foundry#1683

Copy link
Member Author

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@war-in war-in merged commit 59a7b1a into master Feb 9, 2024
10 checks passed
@war-in war-in deleted the feature/compile-raw-sierra branch February 9, 2024 10:43
CompileContract(CompileContract),

// Compile sierra program (cairo_lang_sierra::program::Program)
CompileRaw(CompileRaw),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be CompileProgram, I would consider bytecode or textual sierra a raw sierra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facilitate compilation of plain sierra programs
4 participants