Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache dependencies between workflows #94

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

km1chno
Copy link
Collaborator

@km1chno km1chno commented Sep 9, 2024

Resolves #93

Changes

  • add Make sure you generated lock file by installing project dependencies. message to error when lock file is not detected
  • find node version file .nvmrc/.node-version/package.json and pass its path to workflows to use in setup node action (create .nvmrc. with node v20.17.0 if no file found)
  • add 'setup node' action in all workflows to cache yarn/npm dependencies and fix node version
  • change installation scripts to npm ci and yarn install --immutable for consistent runs
  • fix some indentation problems in workflow templates

@km1chno km1chno self-assigned this Sep 9, 2024
@km1chno km1chno linked an issue Sep 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@maciekstosio maciekstosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@km1chno km1chno merged commit 74b42dd into main Sep 12, 2024
3 checks passed
@km1chno km1chno deleted the @km1chno/feat-cache-dependencies-between-workflows branch September 12, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache dependencies between workflows
2 participants