fix(Android,Fabric): pressable on Screen loses focus on pointer movement

[kkafar]

Description

Important

This PR aims to fix only pressables on screen components. This PR does not fix similar pressable issue with pressables in native header. That interaction will be fixed separately.

Pressable elements work just fine until there's a gesture involved. On sensitive physical devices even a little movement during the press is treated as a gesture.

When the Pressable element detects a gesture it calls onResponderMove which then checks wether the gesture happened within the element or went outside by comparing the touch coordinates with coordinates of the element using _isTouchWithinResponderRegion.

The responderRegion is obtained from _responderID and happens to have unexpected values when the native header is present. It tuns out that the Y origin is slightly off. After some further investigation and comparison of coordinates it turned out that the height of the android status bar is not well calculated in various scenarios:

statusBarHidden: true	statusBarTranslucent: true	statusBarTranslucent: false

The calculateHeaderHeight used for calculating the header and statusBar height seems to be the problem. Luckily, we don't have to calculate it by ourselves anymore, because the correct t value is provided in the onLayout function of the Screen. Thus we can get rid of the custom function.

Another issue found: after navigating to another screen the offset is off again (exactly by 2x). It's caused by changes introduced in this PR, which was supposed to prevent content jumps, but doesn't work since RN 0.75 sadly.

I found out that FrameOriginCorrection is not being unset when dimensions from JVM are received, while the FrameHeightCorrection is. After adding the missing unset for FrameOriginCorrection I rolled back to the commit with the mentioned PR merged and RN 0.74 and I can confirm it works.

Fixes #1975

Changes

• removed calculateHeaderHeight function
• added unset for FrameOriginCorrection when dimensions from JVM are received
• added Test1975.tsx repro
• moved code responsible for determining header height during the very first render from component descriptor's adopt method to shadow node appendChild.

Test code and steps to reproduce

TestHeader, Test1975

Checklist

• Included code example that can be used to test this change
• Ensured that CI passes

[WoLewicki]

I'd still wait for @kkafar to come back and elaborate why he wanted to leave the FrameOriginCorrection set.

[kkafar]

@WoLewicki I've left FrameOriginCorrection set after receiving initial update from JVM side, "to ensure correct values in layout metrics of shadownode" <- without this, the Screen's origin position would be (0, 0) - which would not take the header into account, however this was not used by our code anywhere.

[WoLewicki]

So it was only for libs like reanimated to correctly read those values from layoutMetrics?

[kkafar]

Okay, this fixes the issue with pressables on screen (but not in header), thus I'm for merging it.

The issue with pressables in header will be handled separately.

[kkafar]

@WoLewicki Exactly, but right now we should prioritise making it work & defer integration with reanimated.

[hosseinmd]

Please release these changes.

[Kaveh-ap]

I'm facing the same issue!
Are there any plans to release these changes?

[WKampel]

The onPress event does not work for me (Android), but only in a specific situation: Inside a scrollview inside a drawer's content, AND scrolled down more than a few pixels. But onPressIn does work. I'm assuming this has the same root cause.

And I'm on the latest beta version (4.0.0-beta.9) so I'm guessing this won't be fixed anytime soon.

[kkafar]

@WKampel, if you mind providing a reproduction we might be quicker to handle this, thanks!