Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add submodules command in yarn, remove Flipper from Example #2092

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

tboba
Copy link
Member

@tboba tboba commented Apr 3, 2024

Description

This PR addresses latest errors on CI, regarding failing compile phases on iOS. It also adds submodules command to package.json, previously removed, since it was breaking other apps, as it was being executed as a postinstall step.

Changes

  • Removed flipper from Example
  • Added submodules command to package.json

Checklist

  • Ensured that CI passes

@tboba tboba merged commit 2803fa4 into main Apr 3, 2024
7 of 8 checks passed
@tboba tboba deleted the @tboba/fix-failing-ci branch April 3, 2024 16:13
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
…oftware-mansion#2092)

## Description

This PR addresses latest errors on CI, regarding failing compile phases
on iOS. It also adds `submodules` command to package.json,
[previously](software-mansion@56ffac1)
removed, since it was breaking other apps, as it was being executed as a
postinstall step.

## Changes

- Removed flipper from Example
- Added submodules command to package.json

## Checklist

- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant