fix: change topScreenFrame and belowTopScreenFrame to match Reanimated API #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
This was referenced May 25, 2024
This was referenced Jun 3, 2024
This was referenced Jun 10, 2024
This was referenced Jul 17, 2024
This was referenced Jul 25, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…d API (software-mansion#2091) ## Description It seems that [here](software-mansion/react-native-reanimated@80bcfd8), Reanimated has changed their API and change the naming of used props to `topScreenStyle` and `belowTopScreenStyle`. This PR resolves this change by matching the naming to their API. ## Changes - Updated Reanimated to nightly 3.9.0 - Changed naming of `topScreenFrame` and `belowTopScreenFrame` props ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that here, Reanimated has changed their API and change the naming of used props to
topScreenStyleandbelowTopScreenStyle. This PR resolves this change by matching the naming to their API.Changes
topScreenFrameandbelowTopScreenFramepropsChecklist