Don't update view tag when null #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
setLocalRefmay be called withnullbeing passed as the argument. This is handled by the conditional in the logic related to layout animations but not when updating the component view tag. There may be cases where component view tag will become null and will be passed toremovePropsFromRegistry, which will then crash on the native side as it assumes it will receive an array of numbers.Assuming this is the correct way to handle this (is it possible that assigning null to view tag is expected here?), then the code may be changed slightly not to repeat the same check and do an early return. Let me know if you prefer that.
Test plan
Just trust me
(I don't have any other reproduction than the Expensify App on the 0.74 upgrade branch (with strict mode enabled, without it everything works) 😞)