Fix modals #1603
Merged
Fix modals #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed RNGHModalUtils This class gave access to ReactModalHostView.DialogRootViewGroup in order to call #onChildStartedNativeGesture() and use instanceof on it. Checks for ReactRootView/DialogRootViewGroup can be unified by utilizing RootView (which both of those classes implement). 2. Always render GestureHandlerRootView This prevents gestures from not being delivered to RNGH when another GestureHandlerRootView is used before modal (e.g. from React Navigation). Note: This isn't an ideal fix since a new orchestrator will be created, preventing modals from interacting with handlers outside of them. However, this use case is rare. Having gestures working in modals is already an improvement.
j-piasecki
approved these changes
Aug 27, 2021
|
Can anyone merge this? 👀 |
|
@jakub-gonet @kmagiera any movement on this its a big blocker |
Closed
fluiddot
pushed a commit
to wordpress-mobile/react-native-gesture-handler
that referenced
this pull request
Feb 25, 2022
Fixes software-mansion#139 Removed RNGHModalUtils This class gave access to ReactModalHostView.DialogRootViewGroup in order to call #onChildStartedNativeGesture() and use instanceof on it. Checks for ReactRootView / DialogRootViewGroup can be unified by utilizing RootView (which both of those classes implement). Always render GestureHandlerRootView This prevents gestures from not being delivered to RNGH when another GestureHandlerRootView is used before modal (e.g. from React Navigation). Note: This isn't an ideal fix since a new orchestrator will be created, preventing modals from interacting with handlers outside of them. However, this use case is rare. Having gestures working in modals is already an improvement.
This was referenced Mar 31, 2022
|
I still have the issue on 2.5.0 with PanGestureHandler inside a Modal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #139
Removed RNGHModalUtils
This class gave access to
ReactModalHostView.DialogRootViewGroupin order tocall
#onChildStartedNativeGesture()and use instanceof on it. Checks forReactRootView/DialogRootViewGroupcan be unified by utilizingRootView(whichboth of those classes implement).
Always render GestureHandlerRootView
This prevents gestures from not being delivered to RNGH when another
GestureHandlerRootView is used before modal (e.g. from React Navigation).
Note: This isn't an ideal fix since a new orchestrator will be created, preventing modals from interacting with handlers outside of them. However, this use case is rare. Having gestures working in modals is already an improvement.
Test plan
Tested on
nestedGHRootViewWithModal.tsxexample.